Skip to content

verify: fix help text#640

Open
jamillambert wants to merge 1 commit into
rust-bitcoin:masterfrom
jamillambert:0619-verify-help
Open

verify: fix help text#640
jamillambert wants to merge 1 commit into
rust-bitcoin:masterfrom
jamillambert:0619-verify-help

Conversation

@jamillambert

@jamillambert jamillambert commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

quiet had ... after it. Remove them.

Clap v4 has API changes that required the below changes:

  • Remove unnecessary cmd.clone() now that get_matches() consumes the command.
  • Replace deprecated get_one::<u8>("quiet") with boolean get_flag("quiet") for the quiet flag.

Closes #631

quiet had ... after it. Remove them.

@satsfy satsfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 0d25aa4

Ran locally, it indeed removes the '...'. The get_flag() is necessary otherwise an error is emitted: "Mismatch between definition and access of quiet. Could not downcast to u8, need to downcast to bool".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

verify: Output of --help is wonky

2 participants